…consequence
With reactphp#138 requiring PHP 7.0 as a minimum we can now add return type
hints to all our public and private functions. To give all functions
return type hints we need the `void` return type, which isn't available
until PHP 7.1. So in order use that we also have to bump the the
minimum required PHP version for this package to PHP 7.1.
The benefit of return type hints is the assurance at language level
of our return values. For ourself and our consumers.

clue approved these changes Oct 7, 2019

jsor approved these changes Oct 7, 2019

WyriHaximus added a commit to WyriHaximus-secret-labs/promise that referenced this pull request

Our current test suite has been around for a while and to keep it in
shape for the future we need to modernize is one in a while.
With the increase to PHP 7.1+ in reactphp#149 we can also bump the PHPUnit
version to 7.

WyriHaximus added a commit to WyriHaximus-secret-labs/promise that referenced this pull request

Our current test suite has been around for a while and to keep it in
shape for the future we need to modernize is one in a while.
With the increase to PHP 7.1+ in reactphp#149 we can also bump the PHPUnit
version to 7.

WyriHaximus added a commit to WyriHaximus-secret-labs/promise that referenced this pull request

Our current test suite has been around for a while and to keep it in
shape for the future we need to modernize is one in a while.
With the increase to PHP 7.1+ in reactphp#149 we can also bump the PHPUnit
version to 7.

WyriHaximus added a commit to WyriHaximus-secret-labs/promise that referenced this pull request

Our current test suite has been around for a while and to keep it in
shape for the future we need to modernize is one in a while.
With the increase to PHP 7.1+ in reactphp#149 we can also bump the PHPUnit
version to 7.

WyriHaximus added a commit to WyriHaximus-secret-labs/promise that referenced this pull request

Our current test suite has been around for a while and to keep it in
shape for the future we need to modernize is one in a while.
With the increase to PHP 7.1+ in reactphp#149 we can also bump the PHPUnit
version to 7.