Copy link Copy Markdown

Member

clue left a comment •

edited

Loading

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changeset looks reasonable to me, but just one question: Is is common knowledge that Throwable is the base of Exception or should we perhaps make this more explicit? It's my understanding most common use cases would likely reject a promise with a subclass of Exception such as RuntimeException (and family) and it might make sense to keep this as a search keyword in the documentation?

Copy link Copy Markdown

Member Author

Good point, i will try to rework the docs 👍 . But we must make sure to not recommend \Exception as type-declarations in callbacks. Used eg. in otherwise() callbacks, this might lead to uncaught \Error's.