WyriHaximus changed the title ~~[WIP] Raise minimum PHP version to 7.0~~ [WIP] Enforce Throwable rejection reason and require PHP 7+ as a consequence

Apr 20, 2019

WyriHaximus changed the title ~~[WIP] Enforce Throwable rejection reason and require PHP 7+ as a consequence~~ Enforce Throwable rejection reason and require PHP 7+ as a consequence

Apr 26, 2019

clue approved these changes May 8, 2019

Bump minimum required and tested PHP version to 7.0 as a result of
requiring Throwables. Renamed the nesecary exceptions, methods and
properties to match the new Throwable naming.

jsor approved these changes May 9, 2019

This was referenced

May 9, 2019

Merged

WyriHaximus added a commit to WyriHaximus-secret-labs/promise that referenced this pull request

Oct 7, 2019

…consequence
With reactphp#138 requiring PHP 7.0 as a minimum we can now add return type
hints to all our public and private functions. To give all functions
return type hints we need the `void` return type, which isn't available
until PHP 7.1. So in order use that we also have to bump the the
minimum required PHP version for this package to PHP 7.1.

WyriHaximus added a commit to WyriHaximus-secret-labs/promise that referenced this pull request

Oct 7, 2019

…consequence
With reactphp#138 requiring PHP 7.0 as a minimum we can now add return type
hints to all our public and private functions. To give all functions
return type hints we need the `void` return type, which isn't available
until PHP 7.1. So in order use that we also have to bump the the
minimum required PHP version for this package to PHP 7.1.
The benefit of return type hints is the ensurance at language level
of our return values. For ourselfs and our consumers.

WyriHaximus added a commit to WyriHaximus-secret-labs/promise that referenced this pull request

Oct 7, 2019

…consequence
With reactphp#138 requiring PHP 7.0 as a minimum we can now add return type
hints to all our public and private functions. To give all functions
return type hints we need the `void` return type, which isn't available
until PHP 7.1. So in order use that we also have to bump the the
minimum required PHP version for this package to PHP 7.1.
The benefit of return type hints is the assurance at language level
of our return values. For ourself and our consumers.

Merged

clue mentioned this pull request