Maciej Mroziński · GitHub

Conversation

@clue

Copy link Copy Markdown

Member

The Request is a WritableStreamInterface and now obeys its method and event semantics.
The Response is a ReadableStreamInterface and now obeys its method and event semantics.

Resolves / closes #70
Supersedes / closes #83
Builds on top of / closes #87 (thanks @maciejmrozinski!)

Maciej Mroziński and others added 5 commits

May 17, 2017 21:11
Accordingly, the `drain` event now behaves consistently and we no longer
need the custom `headers-written` event.

@WyriHaximus

@clue clue mentioned this pull request

May 19, 2017

Merged

jsor

jsor approved these changes May 19, 2017

WyriHaximus

@WyriHaximus

@clue

clue deleted the stream branch

May 19, 2017 12:44

@clue clue mentioned this pull request

May 19, 2017

Merged

@Fneufneu

Copy link Copy Markdown

I'm a bit late but you forget to update README.

$response->on('data', function ($data, $response) {

should be

$response->on('data', function ($data) {

@WyriHaximus

Copy link Copy Markdown

Member

Feel free to open a PR fixing this 👍

@clue clue mentioned this pull request

Jun 16, 2017

Merged

@clue

Copy link Copy Markdown

Member Author

Read the original on github.com ↗