Contributor

To avoid TypeError when overflow to float

Don't know if it worth to be fixed as deprecated component... BTW, minor patch

Member

@remicollet Thanks! Is the same bug also present in react/http? As far as I'm considered, it's deprecated but a small bug fix like this we can release. We just wouldn't communicate it

Contributor Author

@WyriHaximus in react/http, another fix is already applied

               $this->chunkSize = @\hexdec($hexValue);
               if (!\is_int($this->chunkSize) || \dechex($this->chunkSize) !== $hexValue) {

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remicollet Thanks for the update to support PHP 8, changes LGTM!

The change itself is indeed very similar to reactphp/http#391, so I agree it makes sense to merge as-is even if this component has been deprecated (#152 / #153).