WyriHaximus · GitHub

@WyriHaximus

Copy link Copy Markdown

Member

This is a backport of #532 and corrects an oversight introduced in #482.

@WyriHaximus

Merged

clue

clue approved these changes Aug 29, 2024

@clue clue left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus Thanks for the backport, changes LGTM. It's a small changeset, but should this use the same authorship information as #532?

@WyriHaximus

Copy link Copy Markdown

Member Author

but should this use the same authorship information as #532?

Sure, will somehow add that information later today 👍

@lucasnetau @WyriHaximus

@WyriHaximus

@WyriHaximus

Copy link Copy Markdown

Member Author

clue

clue approved these changes Aug 30, 2024

@clue clue left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus Thanks for the update, changes LGTM! :shipit:

@clue

@WyriHaximus

WyriHaximus deleted the 1.x-fix-expected-error-code-in-tests-when-ext-sockets-is-not-enabled branch

August 30, 2024 10:10

Read the original on github.com ↗