Conversation

Copy link Copy Markdown

Contributor

Currently only requests with a body will emit the end event ( #116 and #129).

This ensures that a completed request without a body (e.g. GET-Request) will emit an end event.

		$request->emit('end');
		$request->close();
		return;
		}

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emitting events on another instance should generally be avoided. Also, this looks somewhat similar to the code below, perhaps this can/should be unified?

Copy link Copy Markdown

Contributor Author

Ping @clue have a look at this new approach.

clue approved these changes Mar 2, 2017

clue left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! 👍

jsor approved these changes Mar 3, 2017

clue mentioned this pull request

Mar 7, 2017

Closed