clue · GitHub

Conversation

@SimonFrings

Copy link Copy Markdown

Member

This pull request builds on top of #227.
Thanks to @broberts-dev for putting the time into these changes!

I rearranged some commits and added a few improvements to the documentation.

Resolves and Closes #227.

Remove a duplicate word ("the") from the comment for `LoopInterface::addPeriodicTimer`.

clue

@clue clue left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thank you for looking into this and taking this over!

Most of the suggestions look good to me, what do you think about the documentation for the callback functions? (see also other callbacks)

@SimonFrings

@SimonFrings

@SimonFrings

clue

clue approved these changes Nov 12, 2021

@clue clue left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue

WyriHaximus

@WyriHaximus

Read the original on github.com ↗