clue ยท GitHub

Conversation

@clue

Copy link Copy Markdown

Member

Classes should be used via composition rather than extension.
This reduces our API footprint and avoids future BC breaks by avoiding
exposing its internal assumptions.

Builds on top of #128

jsor

jsor approved these changes Dec 4, 2017

WyriHaximus

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ‘

@jsor

Copy link Copy Markdown

Member

@WyriHaximus

Copy link Copy Markdown

Member

@jsor funny enough before one loop can't be mocked ๐Ÿ˜‚

@clue

@clue

Copy link Copy Markdown

Member Author

Rebased now that #132 is in, this should fix the build error :shipit:

@WyriHaximus

Copy link Copy Markdown

Member

Yup looks good ๐Ÿ‘

@WyriHaximus

@clue

Read the original on github.com โ†—