clue · GitHub

The mixed "data" attribute is mostly unused and can easily be replaced
by closure binding instead.
This also prepares the timer instance to become an immutable
data structure.
These can easily be replaced by Loop::cancelTimer() and
Loop::isTimerActive().
This change ensures that timers are now a plain immutable data structure
and offer no methods to change its state.
This also prepares the timer to remove the cyclic dependency with the
loop instance.
Thid can easily be replaced by using closure binding as documented.

@clue

@clue clue mentioned this pull request

Apr 26, 2017

Merged

@WyriHaximus

WyriHaximus

nrk

nrk approved these changes Apr 27, 2017

jsor

jsor approved these changes Apr 28, 2017

@WyriHaximus

@clue

clue deleted the timers branch

April 28, 2017 19:39

@clue clue mentioned this pull request

Oct 13, 2017

Merged

@clue clue mentioned this pull request

Nov 10, 2017

Merged

@clue clue mentioned this pull request

Dec 4, 2017

Merged

@clue clue mentioned this pull request

Dec 23, 2017

Merged

@clue clue mentioned this pull request

Apr 3, 2018

Merged

This was referenced

Jul 29, 2018

Merged

Merged

@clue clue mentioned this pull request

Jan 3, 2021

Closed

Read the original on github.com ↗