Conversation
Member
The fact that a promise can also be rejected with a Throwable and/or Exception is implied and there is no need to also define that here.
Refs: reactphp/promise#223
Closed
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed this should also be applied to the README documentation. @WyriHaximus is this something you can look into? 👍
The fact that a promise can also be rejected with a Throwable and/or Exception is implied and there is no need to also define that here. Refs: reactphp/promise#223
Member Author
Just noticed this should also be applied to the README documentation. @WyriHaximus is this something you can look into? +1
@clue Just updated the README documentation and amended those changes to this PR.
clue approved these changes Jan 25, 2023
