This only reports an error on PHP 7.4 when executed like this: $ vendor/bin/phpunit --coverage-text --exclude-group internet
Merged
clue added a commit to clue-labs/reactphp that referenced this pull request
Jul 10, 2020
The build error on PHP 7.4 will be addressed via reactphp/dns#164. Interestingly, it fails in the `FunctionalResolverTest` class and does not fail anymore by excluding any other test file, e.g. `CoopExecutorTest`. It can only be reproduced by running: ``` $ vendor/bin/phpunit --coverage-text --exclude-group internet ``` It can not be reproduced when running on any other PHP version, when `ext-xdebug` is disabled, when coverage is not collected or when not excluding this group. This means the test failure is bogus. We work around this by temporarily skipping one test case for now.
clue added a commit to clue-labs/reactphp that referenced this pull request
Jul 10, 2020
The build error on PHP 7.4 will be addressed via reactphp/dns#164. Interestingly, it fails in the `FunctionalResolverTest` class and does not fail anymore by excluding some other test cases. It can only be reproduced by running: ``` $ vendor/bin/phpunit --coverage-text --exclude-group internet ``` It can not be reproduced when running on any other PHP version, when `ext-xdebug` is disabled, when coverage is not collected or when not excluding this group. This means the test failure is bogus. We work around this by temporarily skipping some test case for now.
jsor approved these changes Jul 11, 2020
clue deleted the tests branch
July 23, 2020 18:30