clue · GitHub

@clue

@clue clue commented

Nov 4, 2018

edited

Loading

Copy link Copy Markdown

Member

TTL is actually a UINT32 with most significant bit unset for BC reasons as per https://tools.ietf.org/html/rfc2181#section-8. This will not affect "normal" operation as the most significant bit should not be set by compliant implementations and we will now interpret this accordingly.

Refs #81
Refs #114

@clue

@clue

WyriHaximus

@kelunik

Copy link Copy Markdown

It's probably best to limit the TTL to a much lower value, such as one day, to mitigate the effect of a successful cache poisoning attack.

@clue

Copy link Copy Markdown

Member Author

@kelunik I think you're raising a valid point when it comes to the caching layer (see #81). However, this PR is concerned with the networking layer. It's my understanding that this layer should therefor implement the DNS protocol specs as suggested in this PR.

@kelunik

Copy link Copy Markdown

@kelunik Indeed, the policy for that shouldn't live in the parser.

jsor

jsor approved these changes Nov 5, 2018

@clue

@clue

@clue clue mentioned this pull request

Jul 8, 2019

Merged

Read the original on github.com ↗