clue · GitHub

@clue clue commented

Dec 6, 2021

edited

Loading

Copy link Copy Markdown

Member

This simple changeset avoids an unneeded (and undeclared!) dependency on ext-filter. The extension is enabled by default, but can explicitly be disabled with --without-filter.

The code in question is already covered by the test suite, so the test suite confirms this changeset does not affect behavior or our public API in any way. Accordingly, this is entirely transparent for all consumers of this package, plus now also supports consumers that happen to use --without-filter.

The changes have been ported from reactphp/dns#185
See https://www.php.net/manual/en/filter.installation.php
Originally reported in leproxy/leproxy#80
Refs reactphp/socket#17

Read the original on github.com ↗