WyriHaximus · GitHub

@WyriHaximus

Copy link Copy Markdown

Member

Événement 3.0 is nearly fully backwards compatible with 2.0 and 1.0 and react/datagram is fully compatible with all three so why not support it. It packs some neat performance upgrades without any code changes on react/datagram's side :shipit: .

@WyriHaximus

@WyriHaximus

@clue

Copy link Copy Markdown

Member

Change LGTM, but IMO this should target the v1.2.0 release as it is actually a new feature, not a bug fix 👍

For the reference: The failing unit tests are unrelated and being addressed in #17.

clue

clue approved these changes Aug 6, 2017

@WyriHaximus

Copy link Copy Markdown

Member Author

this should target the v1.2.0 release as it is actually a new feature

Don't entirely agree as this doesn't add new features from a users point, it just ensure forward support for a package used in this package. But 🤷‍♂️ , v1.2.0 works just as well as v1.1.2 😄

jsor

jsor approved these changes Aug 7, 2017

@WyriHaximus

Read the original on github.com ↗