nhedger ยท GitHub

@nhedger

Copy link Copy Markdown

Contributor

Merged

clue

@clue

clue commented

Jun 20, 2022

โ€ข

edited

Loading

Copy link Copy Markdown

Member

The build error is unrelated to this changeset and is actually caused by an upstream regression in PHP 8.1.7 and PHP 8.0.20 only (see php/php-src#8575, php/php-src#8571 and php/php-src#8827). There's ongoing effort to revert this for upcoming PHP versions again, so the build should be green again by then, no changes required here.

@nhedger

@clue

Copy link Copy Markdown

Member

The build error is unrelated to this changeset and is actually caused by an upstream regression in PHP 8.1.7 and PHP 8.0.20 only (see php/php-src#8575, php/php-src#8571 and php/php-src#8827). There's ongoing effort to revert this for upcoming PHP versions again, so the build should be green again by then, no changes required here.

See #96 for temporary test adjustments to skip affected tests.

clue

clue approved these changes Jun 21, 2022

@clue clue left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhedger Thanks for the quick update, changes LGTM! ๐Ÿ‘

@clue

WyriHaximus

@WyriHaximus

@nhedger

nhedger deleted the chore/remove-leading-dollar branch

June 24, 2022 09:58

Read the original on github.com โ†—