Member
This simple PR removes the unused options passed to proc_open(). These options only affect behavior on Windows (suppress_errors and bypass_shell options) which is currently not supported anyway (#9). They are not documented or referenced anywhere else in this library anyway, so while this may technically be a BC break, its actual impact should be relatively small.
Member
With limited windows support coming back in v0.6.0 I don't really see a reason to remove this to be honest.
Member Author
@WyriHaximus Valid point! This is something I have prepared and will look into in a follow-up PR. This PR is a preparation for this and removes these options simply because they provide no value whatsoever currently. They may be re-introduced in one of the follow-up PRs with some proper tests/documentation to veriify correct execution on Windows 👍
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clue sounds good to me 👍
jsor approved these changes Nov 25, 2018
clue deleted the options branch
November 25, 2018 20:23