mastahyeti ยท GitHub

added 2 commits

February 8, 2017 11:23

eileencodes

jeremy

rename config option. fix tests.
s/effective_column_names/attribute_names_and_aliases/
s/effective_column_name?/attribute_name_or_alias?/
move pluck column checking logic into its own method
document unsafe_raw methods
๐Ÿ’„
s/attribute_name_or_alias?/respond_to_attributes?/
optimize respond_to_attributes?
remove attribute_names_and_aliases
๐Ÿ’„
typo
dedup pluck/unsafe_raw_pluck logic with private method
only call restrict_order_args unless unsafe-raw enabled
๐Ÿ’„
refactor a bit
typo
test unsafe_raw methods too (and fix them)

btoews

@mastahyeti

@mastahyeti

jeremy

@btoews

btoews deleted the unsafe_raw_sql branch

January 5, 2018 16:23

Closed

flackou pushed a commit to flackou/geokit-rails that referenced this pull request

Apr 17, 2018

Julien Lestavel

Closed

Closed

JasonBarnabe pushed a commit to kickbooster/wice_grid that referenced this pull request

Jun 28, 2018

Jason Barnabe

Ref: rails/rails#27947
- Use Arel objects instead of Strings whenever we can
- Allow Arel objects with custom_order option
- Add tests for Arel and Proc custom_orders
- Update readme and changelog

Merged

Closed

Merged

Closed

Closed

@stgm stgm mentioned this pull request

Dec 28, 2019

Closed

Closed

@Hamms Hamms mentioned this pull request

Nov 3, 2020

Closed

8 tasks

Merged

Merged

Open

Read the original on github.com โ†—