Member

This restores the text_* properties for message to the way they were.
Implementing different methods for different behavior can be done either in this PR or in another.

fixes #773

Member Author

I modified as requested.
properties now available are:
text_html <- does not encode MessageEntity.URL
text_html_urled < encodes MessageEntity.URL
text_markdown <- does not encode MessageEntity.URL
text_markdown_urled < encodes MessageEntity.URL

Member

Hmm maybe add a docstring link from the urled one to the not urled one and vise versa?
Other than that LGTM

Member Author

@bomjacob they should be listed right on top of each other in docstrings. I think it's a bit overkill

Member

That may be true, but I still think it makes more sense from a usability standpoint. Especially if you consider that people don't necessarily search through the docs themselves, they might be linked by roolsbot or be using the internal help() command.

@bomjacob
about this in your comment:
text_html <- does not encode MessageEntity.URL

does not encode if the user didn't use html tags, but does it returns the html tags if the user sent the message using them?

Member Author

@91DarioDev in that case it would be a MessageEntity.TEXT_LINK which is always encoded

Member

LGTM. @Eldinnie has proper unitest wip with the new unitests so no need for that here.