Conversation
Copy link
Copy Markdown
Member
Check-list for PRs
- Added
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION,.. deprecated:: NEXT.VERSIONor ``.. versionremoved:: NEXT.VERSION` to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes) - Created new or adapted existing unit tests
- Documented code changes according to the CSI standard
[ ] Added myself alphabetically toAUTHORS.rst(optional)- Added new classes & modules to the docs and all suitable
__all__s - Checked the Stability Policy in case of deprecations or changes to documented behavior
If the PR contains API changes (otherwise, you can ignore this passage)
-
Checked the Bot API specific sections of the Stability Policy
-
[ ] Created a PR to remove functionality deprecated in the previous Bot API release (see here) -
New Classes -
Added New Shortcuts
- In
telegram.Chat&telegram.Userfor all methods that acceptchat/user_id [ ] Intelegram.Messagefor all methods that acceptchat_idandmessage_id[ ] For newtelegram.Messageshortcuts: Addedquoteargument if methods acceptreply_to_message_id[ ] Intelegram.CallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_id
- In
-
If Relevant
- Added new constants at
telegram.constantsand shortcuts to them as class variables - Linked new and existing constants in docstrings instead of hard-coded numbers and strings
[ ] Added new message types totelegram.Message.effective_attachment[ ] Added new handlers for new update types[ ] Added new filters for new message (sub)types- Added or updated documentation for the changed class(es) and/or method(s)
- Added the new method(s) to
_extbot.py - Added or updated
bot_methods.rst [ ] Updated the Bot API version number in all places:README.rst(including the badge) andtelegram.constants.BOT_API_VERSION_INFO[ ] Added logic for arbitrary callback data intelegram.ext.ExtBotfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.Message
- Added new constants at
Closed
35 tasks
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good just two comments