Member
- references to BusinessBotRights can be added once implemented. the attributes are mentioned in the docs of the bot methods
- naming of
Message.read_business_messagecan be discussed. JustMessage.readdoesn't sufficiently highlight the business connection IMO butMessage.read_business_messageis the complete name again … not really happy with it.
Closed
35 tasks
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Changes look good 😄 , just left some minor comments.
| user = User(1, "first", False) | ||
| user_chat_id = 1 | ||
| date = dtm.datetime.utcnow() | ||
| can_reply = True |
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the set_business_account_profile_photo and remove_business_account_profile_photo methods are missing, not sure if that was intentional or not...
I'm fine with the naming of message.read_business_message. Rest of the changes look good to me!
Member Author
the set_business_account_profile_photo and remove_business_account_profile_photo methods are missing, not sure if that was intentional or not...
Yup, those require new classes which I didn't have time to implement yet :)
I'm fine with the naming of message.read_business_message. Rest of the changes look good to me!
🥳
Co-authored-by: Abdelrahman Elkheir <90580077+aelkheir@users.noreply.github.com>