Contributor
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thanks for the catch and also for already providing a PR!
The annotation change itself looks ok for me. However, both the docstring and method implementation will need adaption as well. See lines 1435, 1463 and 1467 (1467 doesn't need adaption, but explains why adaption of 1463 is needed). Please be sure to adapt/extend unit tests if required. I'd say this change also warrants a "versionchanged" directive. Please have a look at the PR-checklist that we link in our PR-Template :)
Contributor Author
Hi! Thanks for the feedback!
I've made the changes you asked, let me know if there's something wrong!
…on.add_handlers
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, then. thanks very much for the contribution and the fast responses!
