Bibo-Joshi · GitHub

Conversation

@Bibo-Joshi

Copy link Copy Markdown

Member

Follow-up for #4454. based on that branch, merge after.
Uses the offline_bot in all the *WithoutRequest tests and fixes the very few places where requests where still being made.
The check for enforcing offline_bot is now configured to run only on GitHub and only in one of the several test matrix runs. IMO this should suffice and avoids running additional if-checks on every single test function unnecessarily.

By cutting of the internet connection in the fixtures

@Bibo-Joshi

harshil21

Base automatically changed from no-request-tests to master

September 9, 2024 05:32
…uest_tests

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Bibo-Joshi

@Bibo-Joshi

2 participants

@Bibo-Joshi @harshil21

Read the original on github.com ↗