aelkheir · GitHub

@aelkheir

@aelkheir aelkheir commented

Sep 8, 2024

edited by Bibo-Joshi

Loading

Copy link Copy Markdown

Member

Closes parts of #4459

Checklist for PRs

  • Added .. versionadded:: NEXT.VERSION, .. versionchanged:: NEXT.VERSION, .. deprecated:: NEXT.VERSION or .. versionremoved:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Checked the Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)

  • Checked the Bot API specific sections of the Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_
  • Created a PR to remove functionality deprecated in the previous Bot API release (see here <https://docs.python-telegram-bot.org/en/stable/stability_policy.html#case-2>_)
  • New classes:
    • Added self._id_attrs and corresponding documentation
    • __init__ accepts api_kwargs as kw-only
  • Added new shortcuts:
    • In :class:~telegram.Chat & :class:~telegram.User for all methods that accept chat/user_id
  • If relevant:
    • Link new and existing constants in docstrings instead of hard-coded numbers and strings
    • Added or updated documentation for the changed class(es) and/or method(s)

Bibo-Joshi

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR! I left only a few minor comments

Bibo-Joshi

Merged

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just doc fixes

harshil21

Bibo-Joshi

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was left hanging in pending …

@Bibo-Joshi

@Bibo-Joshi

@Bibo-Joshi

Copy link Copy Markdown

Member

Thank you a lot for the nice and fast PR!

Read the original on github.com ↗