Member

By cutting of the internet connection in the fixtures

• provide a new fixture offline_bot that has no internet connection
• override fixtures for the tests in ext to have no internet connection
• manually adapt a few tests
• also move other ext-only-fixtures from conftest to ext\conftest on the fly

Let's see if I got everything in local testing

supersedes #4317. Although this PR here doesn't cover cutting off the internet connection in the *WithoutRequest tests, I don't think I'll follow up on that for the reasons pointed out in #4317.

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good to me. Regarding the WithoutRequest tests, after we use offline_bot there as well, I'm wondering if we can disallow the bot fixture to be used in those tests. As you mentioned, it's close to impossible to effectively enforce this, but it's a decent try.

We can get the fixture list using fixturenames it seems.

Member Author

Alright, looks good to me. Regarding the WithoutRequest tests, after we use offline_bot there as well, I'm wondering if we can disallow the bot fixture to be used in those tests. As you mentioned, it's close to impossible to effectively enforce this, but it's a decent try.

I would like to move this to a different PR …

Member Author

All right. Looks like I've got all tests working by now and also managed to reduce repetitions a bit. So now actually ready for review 😅