Bibo-Joshi · GitHub

@Bibo-Joshi

Copy link Copy Markdown

Member

outsources the code to a reusable component. I'm also using this in aiorem now.

@Bibo-Joshi

@Bibo-Joshi

@harshil21

Copy link Copy Markdown

Member

Interesting. Are there any functional changes to it apart from it being outsourced?

Also, can you deliberately change something so that the test fails (so that I know it's actually working) 😅

@Bibo-Joshi

Copy link Copy Markdown

Member Author

Interesting. Are there any functional changes to it apart from it being outsourced?

currently PTB allows a 0.1% decrease of type completeness - I threw that out for now.

Also, can you deliberately change something so that the test fails (so that I know it's actually working) 😅

Will do :)

@Bibo-Joshi

Copy link Copy Markdown

Member Author

well, shit :D

@Bibo-Joshi

@Bibo-Joshi

Copy link Copy Markdown

Member Author

@Bibo-Joshi

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good thing that was tested!

@Bibo-Joshi

@Bibo-Joshi

Bibo-Joshi deleted the composite-action-type-completeness branch

July 10, 2024 15:33

Read the original on github.com ↗