Copy link Copy Markdown

Contributor

add adjust_message_entities_to_utf_16 for #4319

Closed

Copy link Copy Markdown

Contributor Author

Is there anything else should be added/changed?

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you very much for the PR! I left a number of comments. The overall logic is fine - thanks for catching the necessity for sorting! - but there are some things that can be improved :)

Copy link Copy Markdown

Contributor Author

Ok, I will fix these in the next few days

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Left some more comments, mostly about documentation :)
Please don't force-push additional changes, as that makes it hard to see what which parts I've already reviewed.

Poolitzer linked an issue

Jul 3, 2024

that may be closed by this pull request

Closed

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional updates! LGTM now :) If @harshil21 approves as well, we can merge.

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last doc fix

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

Copy link Copy Markdown

Member

Thank you very much for the nice contribution!

Closed