Bibo-Joshi · GitHub

@Bibo-Joshi

Copy link Copy Markdown

Member

Explicitly catches and logs exceptions in creating Callback context objects. Relevant particularly if the user uses a custom class that overrides from_update. Since from_error calls from_update, exceptions in from_update can currently completely shut down update processing and error handling. See https://t.me/pythontelegrambottalk/253238 for reference.
Work in progress, e.g. tests are still missing.

@Bibo-Joshi

@Bibo-Joshi

@Bibo-Joshi

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting edge case scenario

harshil21

Poolitzer

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi

@Bibo-Joshi

Bibo-Joshi deleted the error-handling-context-building branch

May 20, 2024 13:25

Read the original on github.com ↗