Member

See #4125 for discussion

Since the tests for these things usually don't run well on Windows, I haven't run the unit tests yet - let's see.
Adding new unit tests will also likely be chellanging. If the test coverage doesn't drop, I might be content with leaving as is 😬

Member Author

All right, tests seem to be stuck. will have to debug on linux

Member Author

Test coverage seems to be fine and as expected adjusting the existing tests was already rather annoying, so tbh I'm not eager to try and add another unit test here.
I manually ran the customwebhook as well, which still works fine.

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Member Author

Didn't have a very close look at the tests.. they are kind of a black box because of so many Event's.

They are certainly not very pretty :/

I assume you ran an example bot on both Windows and linux and checked if Ctrl+C works well?

Yes, I ran echobot & the example from #4125.