Bibo-Joshi · GitHub

@Bibo-Joshi

Copy link Copy Markdown

Member

No description provided.

…m.constants`

@Bibo-Joshi

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I had seen some places where this was missed. Is there a way to easily test this for all classes (test should probably assume that self.type needs an enum reference)

@Bibo-Joshi

@Bibo-Joshi

Copy link Copy Markdown

Member Author

Added a simple regex testcase and actually found another place to apply the change. I excluded passport stuff - we don't have enums for that and I don't like touching that stuff if not really necessary 😬

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general test case looks good and I'm fine with excluding the passport directory!

@Bibo-Joshi

@Bibo-Joshi

kenjitagawa pushed a commit to kenjitagawa/python-telegram-bot that referenced this pull request

Jan 23, 2024

Read the original on github.com ↗