Copy link
Copy Markdown
Member
- Follow up for Add Parameter
socket_optionstoHTTPXRequest#3935 - Also adds tests that make sure that
ApplicationBuilderhas all necessary methods
- Added
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSIONor.. deprecated:: NEXT.VERSIONto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes) - Created new or adapted existing unit tests
- Documented code changes according to the
CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__ Added myself alphabetically toAUTHORS.rst(optional)Added new classes & modules to the docs and all suitable__all__s- Checked the
Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior
* Follow up for #3935 * Also adds tests that make sure that `ApplicationBuilder` has all necessary methods
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did look through the code and it looks fine but I don't feel like I'm qualified enough to judge :)
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code in general looks good to me.