Member
Checklist
- Added
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSIONor.. deprecated:: NEXT.VERSIONto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes) - Created new or adapted existing unit tests
- Documented code changes according to the
CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__ - Added myself alphabetically to
AUTHORS.rst(optional) - Added new classes & modules to the docs and all suitable
__all__s - Checked the
Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior - Create PR to remove functionality deprecated in this PR
If the PR contains API changes (otherwise, you can ignore this passage)
-
Checked the Bot API specific sections of the Stability Policy
-
New classes:
- Added
self._id_attrsand corresponding documentation -
__init__acceptsapi_kwargsas kw-only
- Added
-
Added new shortcuts:
- In :class:
~telegram.Chat& :class:~telegram.Userfor all methods that acceptchat/user_id - In :class:
~telegram.Messagefor all methods that acceptchat_idandmessage_id - For new :class:
~telegram.Messageshortcuts: Addedquoteargument if methods acceptsreply_to_message_id - In :class:
~telegram.CallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_id
- In :class:
-
If relevant:
- Added new constants at :mod:
telegram.constantsand shortcuts to them as class variables - Link new and existing constants in docstrings instead of hard-coded numbers and strings
- Add new message types to :attr:
telegram.Message.effective_attachment - Added new handlers for new update types
- Add the handlers to the warning loop in the :class:
~telegram.ext.ConversationHandler - Added new filters for new message (sub)types
- Added or updated documentation for the changed class(es) and/or method(s)
- Added the new method(s) to
_extbot.py - Added or updated
bot_methods.rst - Updated the Bot API version number in all places:
README.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION_INFO - Added logic for arbitrary callback data in :class:
telegram.ext.ExtBotfor new methods that either accept areply_markupin some form or have a return type that is/contains :class:~telegram.Message
- Added new constants at :mod:
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)
Member
Not sure with the versionchanged text at the promote shortcut and not sure if there should be a versionchanged within the message class where only the docstring was extended.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice PR! I left a couple of minor comments. Additionally, kindly double check with the changes in https://t.me/bot_api_changes/96 & 97. I saw one change in WriteAccessAllowed & there are also a couple of changes in the can_* argument docstrings. Or did everything of that go into doc-fixes alngo with 3c2642f ?
Closed
Merged
4 tasks
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM