Copy link Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (optional) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the additional dependencies for the hooks in sync with the requirements :)

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta question: I guess you kept track of the changelog and added the new rules manually?

Copy link Copy Markdown

Member Author

Meta question: I guess you kept track of the changelog and added the new rules manually?

at first no, I went through the whole list again, but with the newer versions released since this PR, yes I tracked the changelog

Copy link Copy Markdown

Member

Meta question: I guess you kept track of the changelog and added the new rules manually?

at first no, I went through the whole list again, but with the newer versions released since this PR, yes I tracked the changelog

Okay. I'm wondering if we can automate that a bit … or at least do that manually on dependabot PRs …

'assert job==job

Copy link Copy Markdown

Member Author

Okay. I'm wondering if we can automate that a bit … or at least do that manually on dependabot PRs …

I'm okay with checking manually on dependabot PRs for now

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) let's wait for the master branch to work again before merging, though …

clot27 pushed a commit that referenced this pull request

Jul 3, 2023