Bibo-Joshi · GitHub

@Bibo-Joshi

Copy link Copy Markdown

Member

Closes #3735

  • Mostly changes ClassVar to Final for all constants
  • Adds some limited usage of the @final decorator for Base{UpdateProcessor, Request}
  • Uses Literal for the http_version argument of HTTPXRequest. Otherwise, Literal is not used due to Literal of enum values python/typing#781

If there are more places, where @final or Literal are useful, please do point them out :)

@Bibo-Joshi

@Bibo-Joshi

lemontree210

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the required in-depth knowledge to suggest more cases of @final that may have been missed

@Bibo-Joshi

lemontree210

@Bibo-Joshi

@Bibo-Joshi

Merged

Read the original on github.com ↗