Member
TODO:
- Mock the
set/get_my_nametest - Update the warnings tests to check with bot
BotandExtBotin the manner of Improve Warning Categories & Stacklevels #3674
Checklist for PRs
- Added
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes) - Created new or adapted existing unit tests
- Documented code changes according to the CSI standard
- Added myself alphabetically to
AUTHORS.rst(optional) - Added new classes & modules to the docs and all suitable
__all__s
If the PR contains API changes (otherwise, you can delete this passage)
-
New classes:
- Added
self._id_attrsand corresponding documentation -
__init__acceptsapi_kwargsas kw-only
- Added
-
Added new shortcuts:
[ ] InChat&Userfor all methods that acceptchat/user_id[ ] InMessagefor all methods that acceptchat_idandmessage_id[ ] For newMessageshortcuts: Addedquoteargument if methods acceptsreply_to_message_id[ ] InCallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_id
-
If relevant:
- Added new constants at
telegram.constantsand shortcuts to them as class variables - Link new and existing constants in docstrings instead of hard coded number and strings
[ ] Add new message types toMessage.effective_attachment[ ] Added new handlers for new update types[ ] Add the handlers to the warning loop in theConversationHandler
[ ] Added new filters for new message (sub)types- Added or updated documentation for the changed class(es) and/or method(s)
- Added the new method(s) to
_extbot.py - Added or updated
bot_methods.rst - Updated the Bot API version number in all places:
README.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION_INFO [ ] Added logic for arbitrary callback data intg.ext.Botfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.Message
- Added new constants at
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)
Merged
2 tasks
Merged
2 tasks
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a question or two:
๐๐ฝ
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Looks like you edited the (optional) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the additional dependencies for the hooks in sync with the requirements :)