Bibo-Joshi · GitHub

@Bibo-Joshi

Copy link Copy Markdown

Member

@Bibo-Joshi

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work cleaning up the tests structure. Maybe worth doing these as well:

  • Adding the ext, inline, passport folders in the tests so we can shift related test files in there. I believe they can have their own conftests as well if that helps in better organizing it

@Bibo-Joshi

@Bibo-Joshi

Copy link Copy Markdown

Member Author

  • Adding the ext, inline, passport folders in the tests so we can shift related test files in there. I believe they can have their own conftests as well if that helps in better organizing it

I guess then it would make sense to mimic the whole directory structure of telegram. I'll have to look more closely into how pytest discovers tests. should have time on the weekend

@Bibo-Joshi

@Bibo-Joshi Bibo-Joshi changed the title Move things from conftest to tests/auxil Tidy up tests directory

Feb 18, 2023

@Bibo-Joshi

@Bibo-Joshi

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi

@Bibo-Joshi

Read the original on github.com ↗