harshil21 · GitHub

@harshil21

Copy link Copy Markdown

Member

Makes PTB use HTTP/2 by default. This requires the httpx[http2] dependency to be installed as well

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@harshil21

github-actions[bot]

Copy link Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

github-actions[bot]

Copy link Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (optional) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the additional dependencies for the hooks in sync with the requirements :)

Bibo-Joshi

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with making HTTP2 the default, but in that case we should at least offer an option to use HTTP1.1 instead, i.e. add a parameter to HTTPXRequest and a method to ApplicationBuilder.

Bibo-Joshi

@harshil21

Bibo-Joshi

@Bibo-Joshi

clot27

@Bibo-Joshi

@Bibo-Joshi

Read the original on github.com ↗