harshil21 · GitHub

Conversation

@harshil21

Copy link Copy Markdown

Member

As discussed in private chat, this was done to reduce users getting confused on why they got this warning if they never used the days parameter in the first place.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

Bibo-Joshi

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting on the docstring change, code LGTM :)

@Bibo-Joshi

@Bibo-Joshi

2 participants

@harshil21 @Bibo-Joshi

Read the original on github.com ↗