lemontree210 · GitHub

@lemontree210

@lemontree210

harshil21

@lemontree210

harshil21

@lemontree210 lemontree210 changed the title replace seealsos with shortcut admonitions Add admonitions

Jan 14, 2023

@lemontree210 lemontree210 linked an issue

Jan 14, 2023

that may be closed by this pull request

Closed

…ions-docfixes-3496

@lemontree210

Bibo-Joshi

this does not affect existing classes
but may be good for the future

@lemontree210

harshil21

harshil21

Bibo-Joshi

@lemontree210

…ions-docfixes-3496

@lemontree210

harshil21

this currently affects nothing but is worth including
`Bot` had a "Returned in" admonition linking
to `ApplicationBuilder` because of a custom generic
there is no need to call `typing.get_args()`
and check its return because `self._resolve_arg()`
has recursive calls anyway.
they only contain Appbuilder's own methods

harshil21

that led to last `elif` being ignored and classes
whose args were typed as strings
were not added to AppBuilder's "Use in"
…ions
* catch `NotImplementedError` propagated from
`._resolve_arg()` and show an informative
error message about which method/attr in which
class triggered the admonition generation error.
* one stray `continue` got left behind

harshil21

@harshil21

@harshil21

harshil21 deleted the shortcut-admonitions-docfixes-3496 branch

January 22, 2023 11:40

Merged

9 tasks

Read the original on github.com ↗