Bibo-Joshi · GitHub

and others added 7 commits

November 28, 2022 18:49

Closed

it was not done completely in #3314
(`user` attr needed addition)
not sure this is correct in the attrs, but
I'm not changing it:
data (:obj:`str` | :obj:`object`)
(it's only `str` in args)
* not sure I had to add the note for `invite_link` to args,
but it is there in Telegram API
* Telegram API contains no explicit limit
for `name` arg/attr

lemontree210

lemontree210

maybe "Can't be a live location" and
limit constants are not needed in attrs,
but it matches Telegram API
`file_size` in attrs had wrong type too

lemontree210

I didn't include Tip and ..seealso from `callback_data`
argument as I assume it is not put into attrs on purpose
it's not really needed, but at least monospace
font was in place, I think, so why not put a reference
from reading the docstr it isn't clear that it's
a method of Bot
I think the 2nd part of docstring for `start_parameter`
 can be useful to understand this attr, despite
 the phrase addressing the generation of the Invoice
…cumentData`

@lemontree210

…-attrs-3109

Base automatically changed from doc-fixes to master

December 15, 2022 14:20

@Bibo-Joshi

@lemontree210

@lemontree210 lemontree210 linked an issue

Dec 16, 2022

that may be closed by this pull request

Closed

…-attrs-3109
…-attrs-3109

@Bibo-Joshi

…-attrs-3109

Bibo-Joshi

It makes sense in attrs but not in args

lemontree210

…-attrs-3109

@lemontree210

@lemontree210

Merged

4 tasks

Bibo-Joshi added a commit that referenced this pull request

Jan 1, 2023
Co-authored-by: Dmitry Kolomatskiy <58207913+lemontree210@users.noreply.github.com>
Co-authored-by: Viicos <65306057+Viicos@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Eisberge <22561095+Eisberge@users.noreply.github.com>
Co-authored-by: Joshua Tang <joshuaystang@gmail.com>

Read the original on github.com ↗