Conversation
Member
Moves the logic of TO.to_dict in subclasses to TelegramObject itself, which was mainly dealing with sequences and converting datetimes to timestamps.
Checklist for PRs
-
Added.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes) - Created new or adapted existing unit tests
- Documented code changes according to the CSI standard
-
Added new classes & modules to the docs and all suitable__all__s
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, and it's not even fridy 🥳 Could you also extend the to_dict tests to make sure that the recursive setting now properly extends to the (nested) lists?
Member Author
Could you also extend the
to_dicttests to make sure that therecursivesetting now properly extends to the (nested) lists?
This is already tested in the classes which have those, e.g. test_to_dict in test_inlinekeyboardmarkup.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DS failure is unrelated. When the tests pass, this LGTM :)