Bibo-Joshi · GitHub

@miles170

Copy link Copy Markdown

Contributor

Add mention_markdown and mention_markdown_v2 and mention_html to Chat class.

Closes #3216.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@miles170

@Bibo-Joshi

Poolitzer

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, quick and well made PR, did not spot a logic fault! Just nitpicking at words, as I usually do.

@miles170

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and swift work. I think we should also add a Raises: block to each of the methods describing when the method fails

harshil21

Poolitzer

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi

@Bibo-Joshi

Copy link Copy Markdown

Member

Thank you very much for your contribution @miles170 :)

@miles170

miles170 deleted the issues-3216-add-mention-xxx-to-chat branch

October 31, 2022 08:46

Read the original on github.com ↗