Bibo-Joshi · GitHub

@HatimZ

Copy link Copy Markdown

Contributor

Refer to #3109, Chat class arguments docstrings and attributes docstrings are unified.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@HatimZ

@Bibo-Joshi

@Bibo-Joshi

Copy link Copy Markdown

Member

Hi. Thanks for the PR! The changes themself look good, but unfortunately, there are some trailing whitespaces. See the pre-commit output for details. Please also check out the contribution guide for details on how to set up the pre-commit hooks locally.

@HatimZ

@HatimZ

Copy link Copy Markdown

Contributor Author

@Bibo-Joshi Hi . I have removed the trailing whitespaces. I hope its good now. Thanks!

@Bibo-Joshi

@Bibo-Joshi

Copy link Copy Markdown

Member

Thank you for the contribution! :)

Merged

11 tasks

Read the original on github.com ↗