Bibo-Joshi · GitHub

Merged

Merged

Conversation

Bibo-Joshi

harshil21

Bibo-Joshi

Bibo-Joshi

Comment on lines +1704 to +1716

if platform.system() == "Windows":

def signal_handler_test_windows(*args, **kwargs):
# this should be empty, but still called once.
assert args == []

monkeypatch.setattr(loop, "add_signal_handler", signal_handler_test_windows)
# this should run through, and we expect the signals to be empty
app.job_queue.run_once(abort_app, 2)
# pass false so it is not default
app.run_webhook(
port=49152, webhook_url="example.com", close_loop=False, stop_signals=False
)
In case we break, we also have timeout now I decided

github-actions[bot]

Bibo-Joshi

harshil21

@Bibo-Joshi

@Bibo-Joshi

Bibo-Joshi deleted the improve_default_signal_handlers branch

June 2, 2022 07:43

Read the original on github.com ↗