harshil21 · GitHub

@harshil21

Copy link Copy Markdown

Member

Closes #3008 by changing the import to ContextTypes.DEFAULT_TYPE.

Also use float() in timerbot.py for setting the timer.

TODO:

  • Update the wiki after release of v20.0a1
  • Update transition script for people upgrading from v20.0a0

@harshil21

github-actions[bot]

Copy link Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

@harshil21

Bibo-Joshi

@harshil21

Bibo-Joshi

Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

Bibo-Joshi

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM. did you check with both pyright and mypy if they can work with the changes? did you try autocompletion also in both VSC + pylance & pycharm?

Bibo-Joshi

@harshil21

Merged

@Bibo-Joshi

@Bibo-Joshi

@Bibo-Joshi

Read the original on github.com ↗