Bibo-Joshi · GitHub

Conversation

@Bibo-Joshi

Copy link Copy Markdown

Member

closes #2974

runs the job every 2nd month. Ignores a number of URLs where it makes sense IMO. Also fixes a bunch.
Doesn't run on PRs for now. If we want that, we have two options:

  • run on all files. After I ignored all the gh pr/issue links, that's actually not too bad performance wise. Would be okay with doing that.
  • if we want to run only on changed files, we'd have to somehow map changed files to the corresponding rst files. IMO not worth the trouble.

Example for a failing test at https://github.com/python-telegram-bot/python-telegram-bot/runs/6339916713?check_suite_focus=true

  • remove the on: push config from the workflow which is currently just there for demo purposes

@Bibo-Joshi

github-actions[bot]

Copy link Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

@Poolitzer

Copy link Copy Markdown

Member

I don't think checking every link in every PR is going to help, potentially loads of checking at once. Just the month run would be fine. We shall see if that gets/is rate limited already anyway.

harshil21

harshil21

@Bibo-Joshi

Copy link Copy Markdown

Member Author

If the two of you are okay with the rest of the changes, I'll remove the on: push and merge :)

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Poolitzer

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi

@Bibo-Joshi

Merged

5 tasks

Read the original on github.com ↗