Bibo-Joshi · GitHub

Conversation

@Bibo-Joshi

Copy link Copy Markdown

Member

Fixes a bug that's due to ChatMember no longer having all the attributes of its new subclasses.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs
… of `ChatMember`

Merged

16 tasks

@harshil21

Copy link Copy Markdown

Member

perhaps we can also adjust its test by testing different ChatMember classes? For e.g. ChatMemberMember to ChatMemberAdministrator

@Bibo-Joshi

Copy link Copy Markdown

Member Author

yes, of course - left the checklist unfilld on purpose ;)

@Bibo-Joshi

@Bibo-Joshi

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just one thought:

@Bibo-Joshi

@Bibo-Joshi

2 participants

@Bibo-Joshi @harshil21

Read the original on github.com ↗