Member
Closes #2871
Checklist for PRs
- Added
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes) - Created new or adapted existing unit tests
- Added myself alphabetically to
AUTHORS.rst(optional) - Added new classes & modules to the docs
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are quick! :)
Please revert the changes to dispatcher (except maybe for _chat_data -> chat_data). they are not related to the PR and tbh they don't change much at all anyway …
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to merge or do you want to extend this PR with dropping insert/replace_bot as discussed? I'm fine with both :)
Member Author
@Bibo-Joshi I think we can merge and probably do that in the asyncio branch since the implementation will likely change anyway
Member
@harshil21 on asyncio, we mainly change where we call the update_*_data methods, but we don't change any internals of the persistence (except from making the methods async). I would like it better for those changes to be in a different PR. We can still merge this one as is though :)
Member Author
okay, lets do it in another PR then 👍🏼
