Member

Visual changes:

• Switch to furo theme.

Code changes:

• Use parallelization to speed up sphinx build times.
• Bump sphinx to 4.3.2

Other changes:

• Use a table to represent bot methods in a compact manner.
• Some doc fixes in jobqueue.py

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

• Color of border buttons are now more subtle and don't 'stand out' that much.
• Fixes the white line on the sidebar border

these are really nice, good idea 👍

• The top white separator line at the beginning of each page was made the same color as background.

Mh, the line is also there in the light theme - maybe just make it a bit more subtle?

• Example box is now a bit rounded to look a bit modern.

I'd prefer to keep this as is, since the boxes arent't changed on the light theme and bc IMHO it doesn't really fit with the rest of the theme …

Member Author

Mh, the line is also there in the light theme - maybe just make it a bit more subtle?

👍🏼

I'd prefer to keep this as is, since the boxes arent't changed on the light theme and bc IMHO it doesn't really fit with the rest of the theme …

Maybe its time to update the light theme too? We can also make the boxes like warnings, notes, etc (slightly) 'rounded'.

I'll also think about adding a toggle to switch between light and dark mode

Member

Maybe its time to update the light theme too? We can also make the boxes like warnings, notes, etc (slightly) 'rounded'.

IMO this should then also cover the boxes for reference links, inline monospace text attribute/method names and so on. Personally, I'm fine with the non-round boxes … Ofc if you enjoy fiddling with CSS, I won't be the buzzkill :) However, it's probably worth to first look around for already existing sphinx themes that you/we like better than the current one.

There are cool ways to do toggles without JS, I researched that a while ago. E.g. https://daveyhert.hashnode.dev/how-to-create-animated-toggle-switches-with-just-css-and-implement-a-dark-mode-feature

should have expected you to say something like that 😄 AFAIK removing JS just for the sake of it isn't always the right thing to do, though

Member

How about furo? even comes with a dropdown thingy that could be used for the bot methods table

Member Author

How about furo? even comes with a dropdown thingy that could be used for the bot methods table

Wow, looks great! Even has a built in theme switcher!
Couldn't find the dropdown thing you were mentioning in their docs though

Member Author

Would be nice to build docs for this branch to test the new theme on mobile

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Member

words can't express how much I love that overhaul, amazing job.

Do we need an auto switch though in the dark light button? Can't we just have it set the proper auto theme, and then users can manually set it to the other if they want?

Member Author

Do we need an auto switch though in the dark light button? Can't we just have it set the proper auto theme, and then users can manually set it to the other if they want?

but the point of the auto theme is that it switches automatically when light/dark mode is enabled?

Member

@harshil21 But why? Are you constantly switching your browsers theme preferences while visiting a website?