Copy link Copy Markdown

Member

Pylint and mypy were failing for me locally after #2646, so I updated the related files a bit. All of my local mypy failures are from the filters module, which I guess will be refactored in #2178 so didn't change that.

Copy link Copy Markdown

Member

Interesting that it failed for you locally while it passed the CI. Could you specify the error messages that you got?

Copy link Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't failing for me, but these changes look fine.